Provide very bare-bones minimal success/error codes for CAN API.#237
Provide very bare-bones minimal success/error codes for CAN API.#237
Conversation
9cd581f to
6c411fe
Compare
|
Thoughts @facchinm ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #237 +/- ##
=======================================
Coverage 95.53% 95.53%
=======================================
Files 16 16
Lines 1075 1075
=======================================
Hits 1027 1027
Misses 48 48 ☔ View full report in Codecov by Sentry. |
|
Definitely agree on the concept. On the numbering, it really depends on the expected pattern to consume these values. Eg: |
|
Ciao @facchinm ☕ 👋 That's allright with me. It is a little bit at odds with the current error definition but I'd say we have a chance right now to create a clean API. What do you think (concerning possible API breakage)? |
|
What about adopting |
This is related to arduino/ArduinoCore-mbed#956 as well as to arduino/ArduinoCore-mbed#924 .
The underlying problem is that different HALs provide different errors and different error codes when it comes to any peripheral usage (though we concern ourselves with CAN in this PR).
I propose to add at least those two very generic error codes at this very moment with the aim to expand error codes (i.e.
CAN_TX_FIFO_FULL) further in the future.